WL#13410: Move testcases in sys_vars and funcs_1 suites that needs MyISAM to a separate .test file
Affects: Server-8.0 — Status: Complete
There are tests in the sys_vars and funcs_1 suites as well as few others that have some testcases running on MyISAM. These are marked with have_myisam.inc and will be skipped on a server built without MyISAM. Currently MyISAM is always compiled in and hence these tests will run. This might change in the future. We do not want entire .test files to be skipped due to a few testcases that need MyISAM. This WL will move the sections that need MyISAM to a separate .test file .
R1 - It shall be possible to run complete MTR test suite on a server that is built without MyISAM engine R2 - Tests that need MyISAM shall not be run when triggered on a server without MyISAM engine R3 - Tests that do not need MyISAM shall run and pass when run on server without MyISAM engine
We earlier marked all tests that require MyISAM with have_myisam.inc file. Some of these tests are only for MyISAM and some have tests for MyISAM and other engines. This WL should separate out MyISAM testcases from tests that have tests for multiple engines. The strategy to be followed in this WL will be roughly as below 1. Tests that contain force_myisam_default. * These tests are exclusively for MyISAM and no change is needed in the .test file 2. Tests that contain have_myisam.inc, but not force_myisam_default - These test files have some sub tests for MyISAM. Move the MyISAM specific parts into a new file (original-test-name_myisam.test) in the same directory and add the following * Add force_myisam_default.inc * Retain have_myisam.inc * Add comments explaining why the test needs MyISAM 3. Remove have_myisam.inc from the original file Note: Not all tests that require MyISAM is covered by have_myisam.inc. There are few tests that does not have "have_myisam.inc" and still have MyISAM reference in the test/subtest. The list have been updated in the below sections.
1.Following tests in sys_vars and func_1 test suites for now which are specific to MyISAM and includes "have_myisam.inc" and "force_myisam_default.inc". sys_vars/t/myisam_stats_method_func.test sys_vars/t/myisam_data_pointer_size_func.test sys_vars/t/sql_low_priority_updates_func.test sys_vars/t/auto_increment_offset_func.test sys_vars/t/concurrent_insert_func.test sys_vars/t/ft_boolean_syntax_func.test sys_vars/t/sql_big_selects_func.test sys_vars/t/max_join_size_func.test sys_vars/t/delay_key_write_func.test sys_vars/t/auto_increment_increment_func.test func_1/t/row_count_func.test 2.Following tests in sys_vars and func_1 test suites have "have_myisam.inc" and do not have force_myisam_default.inc. funcs_1/t/is_cml_myisam.test funcs_1/t/is_columns_myisam.test funcs_1/t/is_engines_myisam.test funcs_1/t/is_key_column_usage.test funcs_1/t/is_tables_myisam.test funcs_1/t/is_tables.test funcs_1/t/myisam_bitdata.test funcs_1/t/myisam_cursors.test funcs_1/t/myisam_func_view.test funcs_1/t/myisam_storedproc_02.test funcs_1/t/myisam_storedproc_03.test funcs_1/t/myisam_storedproc_06.test funcs_1/t/myisam_storedproc_07.test funcs_1/t/myisam_storedproc_08.test funcs_1/t/myisam_storedproc_10.test funcs_1/t/myisam_trig_0102.test funcs_1/t/myisam_trig_03e.test funcs_1/t/myisam_trig_03.test funcs_1/t/myisam_trig_0407.test funcs_1/t/myisam_trig_08.test funcs_1/t/myisam_trig_09.test funcs_1/t/myisam_trig_1011ext.test funcs_1/t/myisam_views-big.test 3.Following MTR tests in sys_vars and func_1 test suites have engine=MyISAM existence but do not include "have_myisam.inc". sys_vars/t/slow_query_log_func sys_vars/t/default_tmp_storage_engine_basic sys_vars/t/default_storage_engine_basic sys_vars/t/character_set_database_func.test
Copyright (c) 2000, 2020, Oracle Corporation and/or its affiliates. All rights reserved.